Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alexa start charging #16

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cahaverl
Copy link
Contributor

I found that the BatteryRemainingAmount returned from the Leaf is in the range [0,12] event when the Leaf has lost some capacity due to battery aging, e.g. BatteryCapacity = 11. This change updates the battery percentage calculation to reflect this, so that the percentage is more accurate and does not go above 100%.

the range [0,12] event when the Leaf has lost some capacity due to
battery aging, e.g. BatteryCapacity = 11. This change updates the
battery percentage calculation to reflect this, so that the percentage
is more accurate and does not go above 100%.
@cahaverl
Copy link
Contributor Author

Hi Scott,

Do you not want to take these changes? Please let me know, because I have a bugfix for the scheduled update code. I could create a concurrent pull request for that, but then we'd have a conflict on deploy.zip.

@ScottHelme
Copy link
Owner

Happy to take changes, just travelling on business right now so can't look into it much. I'm getting the train back soon so should be around over the weekend and next week. Feel free to create a new PR with bug fixes.

@cahaverl
Copy link
Contributor Author

Hi Scott,

I've added the fix for scheduled update. I've been using this version for about 2 months now, but I've been delayed sending this bug fix due to starting a new job ;^).

Carl

PhilDye added a commit to PhilDye/AlexaNissanLeaf that referenced this pull request Nov 26, 2017
@arussell
Copy link

It looks like this original version might be abandoned. I've fixed this issue on my fork at https://github.com/arussell/AlexaNissanLeaf .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants