Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow bridging if cast window is active #95

Merged
merged 3 commits into from
Feb 15, 2024
Merged

Allow bridging if cast window is active #95

merged 3 commits into from
Feb 15, 2024

Conversation

alexkeating
Copy link
Collaborator

@alexkeating alexkeating commented Dec 22, 2023 •
edited
Loading

Description

  • Before we only allowed bridging during the L2 internal voting period, but instead we should allow vote bridging during the cast window

@alexkeating
Copy link
Collaborator Author

alexkeating commented Dec 22, 2023 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@alexkeating alexkeating mentioned this pull request Dec 22, 2023
Merged
@alexkeating alexkeating force-pushed the feature/do-not-restrict-bridge branch from 368163b to 6a7a490 Compare January 2, 2024 16:43
@alexkeating alexkeating marked this pull request as ready for review January 2, 2024 22:31
@alexkeating alexkeating changed the title Work in progress Allow bridging if cast window is active Jan 3, 2024
wildmolasses
wildmolasses reviewed Jan 19, 2024
View reviewed changes
Copy link
Contributor

@wildmolasses wildmolasses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few nits, thanks @alexkeating

src/L2GovernorMetadata.sol Outdated Show resolved Hide resolved
src/WormholeL2GovernorMetadata.sol Outdated Show resolved Hide resolved
src/optimized/WormholeL2GovernorMetadataOptimized.sol Outdated Show resolved Hide resolved
test/L2VoteAggregator.t.sol Outdated Show resolved Hide resolved
test/WormholeL1VotePool.t.sol Outdated Show resolved Hide resolved
@alexkeating alexkeating force-pushed the feature/do-not-restrict-bridge branch from 1076dfc to 0484817 Compare January 22, 2024 18:45
@alexkeating alexkeating changed the base branch from feature/flexible-voting-support to main February 12, 2024 22:39
@alexkeating alexkeating force-pushed the feature/do-not-restrict-bridge branch from 0484817 to 5fdfc49 Compare February 12, 2024 22:40
@alexkeating alexkeating force-pushed the feature/do-not-restrict-bridge branch from 5fdfc49 to 3faec36 Compare February 12, 2024 22:51
@github-actions GitHub Actions
Copy link

Coverage after merging feature/do-not-restrict-bridge into main will be

94.74%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   L1VotePool.sol100%100%100%100%
   L2CountingFractional.sol81.03%55.56%100%90.63%118, 118, 163, 163, 170, 170, 200–202, 94, 94
   L2GovernorMetadata.sol93.33%75%100%100%103
   L2VoteAggregator.sol96.05%87.50%100%97.62%135, 216, 266
   WormholeL1ERC20Bridge.sol96.15%83.33%100%100%78
   WormholeL1GovernorMetadataBridge.sol100%100%100%100%
   WormholeL1VotePool.sol100%100%100%100%
   WormholeL2ERC20.sol100%100%100%100%
   WormholeL2GovernorMetadata.sol100%100%100%100%
   WormholeL2VoteAggregator.sol100%100%100%100%
   WormholeReceiver.sol100%100%100%100%
   WormholeSender.sol100%100%100%100%
src/optimized
   WormholeL2GovernorMetadataOptimized.sol100%100%100%100%
   WormholeL2VoteAggregatorCalldataCompressor.sol82.22%85.71%80%80.77%126–128, 128, 128–130

@alexkeating alexkeating merged commit 319d660 into main Feb 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wildmolasses wildmolasses wildmolasses approved these changes

@apbendi apbendi Awaiting requested review from apbendi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexkeating @wildmolasses