Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tally compatible functions #66

Merged
merged 6 commits into from
Oct 3, 2023
Merged

Add Tally compatible functions #66

merged 6 commits into from
Oct 3, 2023

Conversation

alexkeating
Copy link
Collaborator

@alexkeating alexkeating commented Sep 25, 2023 •
edited
Loading

Description

  • Add functions to L2VoteAggregator to be compatible with Tally

Closes #19

This was referenced Sep 25, 2023
Merged
Merged
Merged
Merged
Merged
@alexkeating
Copy link
Collaborator Author

alexkeating commented Sep 25, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@alexkeating alexkeating mentioned this pull request Sep 25, 2023
Merged
@alexkeating alexkeating force-pushed the feature/handle-cancelled-proposal branch from 81139aa to acdd800 Compare September 25, 2023 19:31
@alexkeating alexkeating force-pushed the feature/make-l2-gov-compatible-with-tally branch from 2bb98a1 to 5ce25f6 Compare September 25, 2023 19:31
alexkeating
alexkeating commented Sep 25, 2023
View reviewed changes
src/L2VoteAggregator.sol Outdated Show resolved Hide resolved
@alexkeating alexkeating force-pushed the feature/handle-cancelled-proposal branch from acdd800 to cfbfc83 Compare September 25, 2023 19:35
@alexkeating alexkeating force-pushed the feature/make-l2-gov-compatible-with-tally branch from 5ce25f6 to 83f655e Compare September 25, 2023 19:35
@alexkeating alexkeating force-pushed the feature/handle-cancelled-proposal branch from cfbfc83 to e070d2d Compare September 26, 2023 15:05
@alexkeating alexkeating force-pushed the feature/make-l2-gov-compatible-with-tally branch 4 times, most recently from 8437381 to 70f414a Compare September 26, 2023 16:12
@alexkeating alexkeating force-pushed the feature/handle-cancelled-proposal branch from 4b481f1 to 9fb73ea Compare September 26, 2023 18:52
@alexkeating alexkeating force-pushed the feature/make-l2-gov-compatible-with-tally branch 2 times, most recently from 2a7c381 to c3d1c6d Compare September 26, 2023 20:13
@alexkeating alexkeating marked this pull request as ready for review September 27, 2023 20:46
@alexkeating alexkeating mentioned this pull request Sep 28, 2023
Merged
@alexkeating alexkeating changed the base branch from feature/handle-cancelled-proposal to main September 28, 2023 17:40
@alexkeating alexkeating force-pushed the feature/make-l2-gov-compatible-with-tally branch from 9583c0e to c455cf8 Compare September 28, 2023 17:40
@alexkeating alexkeating mentioned this pull request Sep 29, 2023
Merged
@alexkeating alexkeating force-pushed the feature/make-l2-gov-compatible-with-tally branch from c455cf8 to 66a1216 Compare September 29, 2023 16:08
apbendi
apbendi reviewed Sep 29, 2023
View reviewed changes
Copy link
Member

@apbendi apbendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some feedback @alexkeating, but overall looking great 👍

src/L2VoteAggregator.sol Show resolved Hide resolved
src/L2VoteAggregator.sol Show resolved Hide resolved
src/L2VoteAggregator.sol Outdated Show resolved Hide resolved
src/L2VoteAggregator.sol Outdated Show resolved Hide resolved
src/L2VoteAggregator.sol Outdated Show resolved Hide resolved
src/L2VoteAggregator.sol Show resolved Hide resolved
src/L2VoteAggregator.sol Show resolved Hide resolved
wildmolasses
wildmolasses approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@wildmolasses wildmolasses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one item to address

src/L2VoteAggregator.sol Outdated Show resolved Hide resolved
src/L2VoteAggregator.sol Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Coverage after merging feature/make-l2-gov-compatible-with-tally into main will be

91.23%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   FakeERC20.sol100%100%100%100%
   L1Block.sol25%100%25%25%23, 27, 31
   L1VotePool.sol100%100%100%100%
   L2GovernorMetadata.sol100%100%100%100%
   L2VoteAggregator.sol89.16%86.36%100%86.67%109, 117, 123, 129, 135, 155, 217, 259, 262
   WormholeL1ERC20Bridge.sol88.89%66.67%100%93.75%101, 106, 79
   WormholeL1GovernorMetadataBridge.sol100%100%100%100%
   WormholeL1VotePool.sol100%100%100%100%
   WormholeL2ERC20.sol95.45%75%100%100%95
   WormholeL2GovernorMetadata.sol100%100%100%100%
   WormholeL2VoteAggregator.sol100%100%100%100%
   WormholeReceiver.sol100%100%100%100%
   WormholeSender.sol100%100%100%100%

apbendi
apbendi approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@apbendi apbendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @alexkeating

@apbendi apbendi merged commit 6b005d0 into main Oct 3, 2023
4 checks passed
This was referenced Oct 5, 2023
Merged
Merged
@apbendi apbendi mentioned this pull request Oct 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wildmolasses wildmolasses wildmolasses approved these changes

@apbendi apbendi apbendi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update voting interfaces to align with the Governor
3 participants
@alexkeating @apbendi @wildmolasses