Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Mongo DB Engine upgrade. #380

Merged
merged 1 commit into from
Oct 24, 2019
Merged

Mongo DB Engine upgrade. #380

merged 1 commit into from
Oct 24, 2019

Conversation

devendra104
Copy link
Member

@devendra104 devendra104 self-assigned this Oct 16, 2019
@devendra104
Copy link
Member Author

Postponing the use of this function for phase2.
The Upgrade pipeline is an in-progress state so once it will be done, we will raise a new PR for it.

@devendra104 devendra104 changed the title Mongo DB Engine upgrade Mongo DB Engine upgrade phase1 Oct 18, 2019
@devendra104 devendra104 requested review from jyejare and ntkathole and removed request for jyejare and ntkathole October 18, 2019 08:16
@devendra104 devendra104 changed the title Mongo DB Engine upgrade phase1 Mongo DB Engine upgrade. Oct 18, 2019
ntkathole
ntkathole approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@ntkathole ntkathole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@devendra104
Copy link
Member Author

Postponing the use of this function for phase2.
The Upgrade pipeline is an in-progress state so once it will be done, we will raise a new PR for it.

The pipeline will be introduced in 6.7 so I will need to accommodate the changes in existing job.

@devendra104 devendra104 requested a review from jyejare October 18, 2019 08:26
jyejare
jyejare reviewed Oct 22, 2019
View reviewed changes
Copy link
Member

@jyejare jyejare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK pending comments.

upgrade/helpers/tasks.py Outdated
"""
The purpose of this method to perform the upgrade of mongo DB database engine
from MMAPv1 to WiredTiger.
:param str upgrade_type: upgrade type would be a string, depends on choice If user
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this from docstring 'upgrade type would be a string' as :param str is already given.

Instead of upgrade_type string parameter. If you want to choose between satellite and capsule, better u go for default parameter as satellite=True else False for capsule.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of upgrade_type string parameter. If you want to choose between satellite and capsule, better u go for default parameter as satellite=True else False for capsule.

Is it right to put an extra check for validation whether it is Satellite or Capsule?

upgrade/helpers/tasks.py Outdated Show resolved Hide resolved
upgrade/helpers/tasks.py Show resolved Hide resolved
@devendra104 devendra104 force-pushed the mongodb_upgrade branch 2 times, most recently from cdc5cc6 to 69db5a0 Compare October 22, 2019 13:44
@jyejare jyejare merged commit f1da97e into SatelliteQE:master Oct 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ntkathole ntkathole ntkathole approved these changes

@jyejare jyejare jyejare approved these changes

Assignees

@devendra104 devendra104

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devendra104 @jyejare @ntkathole