Frame extraction with reencoding

[sfmig]

Some improvements / additions to the frame extraction slurm script

• optionally reencode videos before extracting frames
• save SLURM logs along with the extracted frames
• save SLURM logs along with the reencoded videos
• derive the file extension from the input video

I deleted the frame extraction only script and the script to extract frames locally.

This PR is a first step towards a more general bash script that would make use of the CLI tools and that we wouldn't edit for each run - some thoughts on that in this draft PR #88 (see this file specifically)

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (224b2bd) 29.81% compared to head (53bbd8c) 29.81%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #78   +/-   ##
=======================================
  Coverage   29.81%   29.81%           
=======================================
  Files           6        6           
  Lines         332      332           
=======================================
  Hits           99       99           
  Misses        233      233           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[samcunliffe]

It's been a while since I've written a longish bash script.

Even though it's a bit out of scope for this PR, we should think about how to test these guys. Like could we call them in CI with a --dryrun flag or something?

You might want to ignore my comments 👇 if there are plans in #88 (I didn't dig into that yet because: rebase.)

[sfmig]

It's been a while since I've written a longish bash script.

Even though it's a bit out of scope for this PR, we should think about how to test these guys. Like could we call them in CI with a --dryrun flag or something?

You might want to ignore my comments 👇 if there are plans in #88 (I didn't dig into that yet because: rebase.)

Yes, testing this would be ideal. I had a quick look and bats seems like a very nice tool for this. IIUC, it can be run in CI too.

Right now we manually edit this script for the different frame extraction jobs. So testing this would be cumbersome. My idea with #88 is to have a bash script that we keep intact, and to which we pass any required parameters as command line arguments. Specifically, we would pass a config.json file that we would read and print to the logs. This way we keep track of what input parameters we passed but the bash script is not edited every time.

So for now I would suggest to merge this PR and add these comments to PR #88. There are other options for unit testing bash scripts, I am adding a brief overview to PR #88 too.

[samcunliffe]

So for now I would suggest to merge this PR...

Agreed.