Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notebook to explore trajectories of escape clips #257

Merged
merged 14 commits into from
Nov 28, 2024

Conversation

sfmig
Copy link
Collaborator

@sfmig sfmig commented Nov 21, 2024

Description

What is this PR?

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
To add:

  • A notebook (.ipynb) to show researchers how to read the crab trajectories using movement and how to make simple plots.
  • A script to generate those two plots for all existing escape clips.

What does this PR do?

  • Adds the files specified above

Other:

  • Renames a previous notebook that examines the predicted vs groundtruth trajectories, to clarify the difference with the new added one.
  • Renames the groundtruth file path.

References

\

How has this PR been tested?

Notebook runs successfully locally.

Does this PR require an update to the documentation?

No.

Checklist:

  • [ n/a ] The code has been tested locally
  • [ n/a ] Tests have been added to cover all new functionality
  • [ n/a ] The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@sfmig sfmig linked an issue Nov 21, 2024 that may be closed by this pull request
2 tasks
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.98%. Comparing base (ef33f58) to head (e2c250f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #257   +/-   ##
=======================================
  Coverage   47.98%   47.98%           
=======================================
  Files          24       24           
  Lines        1567     1567           
=======================================
  Hits          752      752           
  Misses        815      815           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfmig sfmig force-pushed the smg/add-movement-notebook branch from 08df1a9 to 0d8befb Compare November 28, 2024 18:40
@sfmig sfmig marked this pull request as ready for review November 28, 2024 18:46
@sfmig sfmig merged commit ba60fa9 into main Nov 28, 2024
7 checks passed
@sfmig sfmig deleted the smg/add-movement-notebook branch November 28, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Escape trajectories with best model so far
2 participants