Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a README for the tracker #226

Merged
merged 7 commits into from
Sep 16, 2024
Merged

Add a README for the tracker #226

merged 7 commits into from
Sep 16, 2024

Conversation

sfmig
Copy link
Collaborator

@sfmig sfmig commented Jul 19, 2024

To document how we evaluate tracker performance and how we define an ID switch.

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.68%. Comparing base (f46e362) to head (25b7004).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #226   +/-   ##
=======================================
  Coverage   46.68%   46.68%           
=======================================
  Files          24       24           
  Lines        1476     1476           
=======================================
  Hits          689      689           
  Misses        787      787           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfmig sfmig requested a review from nikk-nikaznan July 19, 2024 14:40
@sfmig sfmig marked this pull request as ready for review July 19, 2024 14:40
@sfmig sfmig force-pushed the smg/tracker-readme branch from a88a7f1 to 4ff8d32 Compare July 19, 2024 14:40
Copy link
Collaborator

@nikk-nikaznan nikk-nikaznan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just small suggestion below. The paragraph is a bit too long, and perhaps ID switch should have its own paragraph as well?

Co-authored-by: nikk-nikaznan <[email protected]>
Signed-off-by: sfmig <[email protected]>
@sfmig sfmig merged commit 6f66d36 into main Sep 16, 2024
@sfmig sfmig deleted the smg/tracker-readme branch September 16, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants