Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include resource name in unit test serialization errors #157

Merged
merged 3 commits into from
Oct 13, 2023
Merged

Conversation

glopesdev
Copy link
Contributor

@glopesdev glopesdev commented Oct 13, 2023

This PR ensures that any unexpected serialization exceptions raised during embedded workflow unit tests are marked with the resource name of the affected workflow, to make it easier to trace the source of the problem.

Binary operators are also now checked for unknown types as they were found to be silently impacted by type refactoring.

Fixes #156

@glopesdev glopesdev added the fix Pull request that fixes an issue label Oct 13, 2023
@glopesdev glopesdev requested a review from aspaNeuro October 13, 2023 21:35
@glopesdev glopesdev merged commit a3d7cfd into main Oct 13, 2023
1 check passed
@glopesdev glopesdev deleted the issue-156 branch October 13, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Pull request that fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure unit test error messages are tagged with the embedded workflow identifier
1 participant