SWC-7185 #5590
Merged
SWC-7185 #5590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demo.integrated.SRC.file.browser.mov |
nickgros
approved these changes
Nov 26, 2024
| @@ -23,6 +26,8 @@ public interface FilesBrowserViewImplUiBinder | |||
|
|
|||
| private EntityTreeBrowser entityTreeBrowser; | |||
| private Widget widget; | |||
| SynapseReactClientFullContextPropsProvider propsProvider; | |||
There was a problem hiding this comment.
Consistency nit
Suggested change
| SynapseReactClientFullContextPropsProvider propsProvider; | |
| private SynapseReactClientFullContextPropsProvider propsProvider; |
| // TODO: Should not need to remount, but currently the parentContainer is not shown if the existing react component is updated | ||
| // TODO: Bug: The tree is not always auto-expanding (to the path to the parent container Id) | ||
| reactFileBrowserContainer.clear(); | ||
| ReactComponent componentContainer = new ReactComponent(); |
There was a problem hiding this comment.
You shouldn't need to create a new ReactComponent instance, you should just be able to create one instance and call render on it with the new ReactElement. But it's possible you tried that and it resulted in another bug.
There was a problem hiding this comment.
Yes, tried. Noted a couple of bugs in TODO comments that would need to be addressed if we're moving forward with this solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.