Move SAC Python containers to multibuild #2085
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Created a staging project on OBS for 6: home:defolos:BCI:Staging:SLE-15-SP6:6-2085 Build ResultsRepository
Repository
Repository
Repository
Repository
Repository
Repository
Repository
Build succeeded ✅ To run BCI-tests against this PR, use the following command: OS_VERSION=15.6 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-2085/ tox -- -n autoThe following images can be pulled from the staging project:
|
dirkmueller
force-pushed
the
sac_python
branch
from
8a943e3 to
00b8dfa
Compare
dirkmueller
force-pushed
the
sac_python
branch
from
00b8dfa to
cf019d5
Compare
This is needed to be able to provide multiple branches. Add 3.9 and 3.11.
So far everything was queued up and then asyncio.gather() was run. however, doing deletes at the same time while other tasks are writing leads to corruption. so we need to sequence it out a little.
dirkmueller
force-pushed
the
sac_python
branch
from
c0f02b6 to
6967aee
Compare
This way ContainerCrate can be instantiated per (os_version, package_name) and we can handle service_replacements properly.
dirkmueller
force-pushed
the
sac_python
branch
from
6967aee to
060c5a3
Compare
dcermak
reviewed
Dec 3, 2024
| _multibuild files. | ||
| """ | ||
|
|
||
| class ContainerCrateAssigner: |
There was a problem hiding this comment.
Can we please stop adding more magic indirection to the code? I already voiced my disagreement with this implicit magic and it keeps getting worse.
There was a problem hiding this comment.
This is a draft PR. the one that needs to move ahead is #2096 instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to be able to provide multiple branches. Add 3.9 and 3.11.