Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -L / --dereference option #36

Merged
merged 13 commits into from
Jun 30, 2024

Conversation

noamraph
Copy link
Contributor

Hi,

I added an equivalent to cp -L = cp --dereference option. I need this for my work, where I want to replace a cp command on NFS which takes forever, and it's using -L. I tried to make it behave like cp -L does: just treat symlinks as if they were really the files or directories they refer to. FWIW, in my work I was able to replace the cp -rL with cpz -L, and it succeeded, reducing the copying time from 49 minutes to 4 minutes!

WDYT?

@noamraph noamraph force-pushed the add-dereference-option branch from 602c778 to a241d32 Compare June 26, 2024 13:30
@noamraph
Copy link
Contributor Author

@SUPERCILEX I now managed to make the tests pass on all platforms. What do you think about this feature/PR?

Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
@SUPERCILEX
Copy link
Owner

reducing the copying time from 49 minutes to 4 minutes

Holy shit! I'm very happy to see such a massive real world improvement, that's awesome.

Can you double check that my changes still work on your end? Then I'll merge.

…ption

# Conflicts:
#	fuc_engine/src/ops/copy.rs
Signed-off-by: Alex Saveau <[email protected]>
@noamraph
Copy link
Contributor Author

reducing the copying time from 49 minutes to 4 minutes

Holy shit! I'm very happy to see such a massive real world improvement, that's awesome.

Indeed! Thank you so much for the project!

Can you double check that my changes still work on your end? Then I'll merge.

I'm out of work now, I hope to test it on Sunday.

Also, your changes also tweak the code to my liking ;)

@SUPERCILEX
Copy link
Owner

Also, your changes also tweak the code to my liking ;)

Yay! I'll be waiting for your confirmation. 👍

@noamraph
Copy link
Contributor Author

@SUPERCILEX I confirm, it still works with our CI!

@SUPERCILEX SUPERCILEX merged commit 3e6e5f7 into SUPERCILEX:master Jun 30, 2024
8 checks passed
@SUPERCILEX
Copy link
Owner

Sweet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants