Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[이단] Chapter10_API & Paging #54

Merged
merged 2 commits into from
Jun 27, 2024
Merged

[이단] Chapter10_API & Paging #54

merged 2 commits into from
Jun 27, 2024

Conversation

bflykky
Copy link

@bflykky bflykky commented Jun 26, 2024 •
edited
Loading

#️⃣ 연관된 이슈

#43


✅ 워크북 체크리스트

  • 모든 핵심 키워드 정리를 마쳤나요?
  • 핵심 키워드에 대해 완벽히 이해하셨나요?
  • 이론 학습 이후 직접 실습을 해보는 시간을 가졌나요?
  • 미션을 수행하셨나요?
  • 미션을 기록하셨나요?

✅ 컨벤션 체크리스트

  • 디렉토리 구조 컨벤션을 잘 지켰나요?
  • pr 제목을 컨벤션에 맞게 작성하였나요?
  • pr에 해당되는 이슈를 연결하였나요?
  • 적절한 라벨을 설정하였나요?
  • 스터디원들에게 code review를 요청하기 위해 reviewer를 등록하였나요?
  • 닉네임/main 브랜치의 최신 상태를 반영하고 있는지 확인했나요?

📌 주안점

@bflykky bflykky added the ✨ Chapter10 챕터 10 label Jun 26, 2024
@bflykky bflykky self-assigned this Jun 26, 2024
@bflykky bflykky changed the base branch from main to idan/main June 26, 2024 14:53
h-ye-ryoung
h-ye-ryoung approved these changes Jun 27, 2024
View reviewed changes
Copy link

@h-ye-ryoung h-ye-ryoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

SoulTree-Lovers
SoulTree-Lovers approved these changes Jun 27, 2024
View reviewed changes
Copy link

@SoulTree-Lovers SoulTree-Lovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿 !

@bflykky bflykky merged commit 2e40af1 into idan/main Jun 27, 2024
@bflykky bflykky deleted the idan/#43 branch June 29, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suuu0719 suuu0719 suuu0719 approved these changes

@h-ye-ryoung h-ye-ryoung h-ye-ryoung approved these changes

@SoulTree-Lovers SoulTree-Lovers SoulTree-Lovers approved these changes

Assignees

@bflykky bflykky

Labels
✨ Chapter10 챕터 10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bflykky @SoulTree-Lovers @h-ye-ryoung @suuu0719