Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@W-17357226: Fix for issue where zero threshold defaulted to select #3853

Merged
merged 1 commit into from
Dec 6, 2024
Merged

@W-17357226: Fix for issue where zero threshold defaulted to select #3853

merged 1 commit into from
Dec 6, 2024

Conversation

aditya-balachander
Copy link
Contributor

W-17357226

Changes:

  • Modified the if clauses from if threshold to if threshold is not None
  • Added tests for 0 threshold to ensure it does not select everything

@aditya-balachander aditya-balachander requested a review from a team as a code owner December 3, 2024 09:44
lakshmi2506
lakshmi2506 approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@lakshmi2506 lakshmi2506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jkasturi-sf
jkasturi-sf approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@jkasturi-sf jkasturi-sf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@aditya-balachander aditya-balachander merged commit 5192132 into main Dec 6, 2024
14 of 19 checks passed
@aditya-balachander aditya-balachander deleted the W-17357226/zero_threshold_issue branch December 6, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lakshmi2506 lakshmi2506 lakshmi2506 approved these changes

@jkasturi-sf jkasturi-sf jkasturi-sf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aditya-balachander @jkasturi-sf @lakshmi2506