Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python 3.8 unit tests on macOS #3777

Merged
merged 1 commit into from
May 3, 2024
Merged

Fix Python 3.8 unit tests on macOS #3777

merged 1 commit into from
May 3, 2024

Conversation

jstvz
Copy link
Contributor

@jstvz jstvz commented May 3, 2024

Importing lxml in Python 3.8 now throws an ImportError on macOS:

Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/_pytest/config/__init__.py", line 743, in import_plugin
    __import__(importspec)
  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/_pytest/assertion/rewrite.py", line 171, in exec_module
    exec(co, module.__dict__)
  File "/Users/runner/work/CumulusCI/CumulusCI/cumulusci/tests/pytest_plugins/pytest_sf_orgconnect.py", line 9, in <module>
    from cumulusci.cli.org import org_remove, org_scratch, org_scratch_delete
  File "/Users/runner/work/CumulusCI/CumulusCI/cumulusci/cli/org.py", line 12, in <module>
    from cumulusci.core.config import OrgConfig, ScratchOrgConfig
  File "/Users/runner/work/CumulusCI/CumulusCI/cumulusci/core/config/__init__.py", line 8, in <module>
    from cumulusci.core.utils import import_global
  File "/Users/runner/work/CumulusCI/CumulusCI/cumulusci/core/utils.py", line 21, in <module>
    from cumulusci.utils.options import parse_list_of_pairs_dict_arg
  File "/Users/runner/work/CumulusCI/CumulusCI/cumulusci/utils/__init__.py", line 20, in <module>
    from .xml import (  # noqa
  File "/Users/runner/work/CumulusCI/CumulusCI/cumulusci/utils/xml/__init__.py", line 5, in <module>
    from lxml import etree as lxml_etree
ImportError: dlopen(/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/lxml/etree.cpython-38-darwin.so, 0x0002): symbol not found in flat namespace '_exsltDateXpathCtxtRegister'

According to the discussion on actions/setup-python#696, macos-latest runners are now on AArch64, while macos-13 is still on x86. This PR switches the 3.8 runner to macos-13 as a workaround.

lxml compilation errors are failing 3.8-macos builds. Possibly related
to actions/setup-python/issues/696
@jstvz jstvz requested a review from a team as a code owner May 3, 2024 21:31
@jstvz jstvz requested a review from vsbharath May 3, 2024 21:31
@jstvz jstvz added the ignore-for-release Don't include in release notes label May 3, 2024
@jstvz jstvz enabled auto-merge (squash) May 3, 2024 21:48
@jstvz jstvz merged commit 54079ca into main May 3, 2024
39 checks passed
@jstvz jstvz deleted the fix-macos-build branch May 3, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release Don't include in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants