Make task options read only when using Pydantic option validation
#3695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally, fixed ListMetadataTypes to use parsed_options instead of options
jstvz
requested changes
Nov 8, 2023
There was a problem hiding this comment.
Looks good, just a minor change (marked with ±).
Emoji Key
| Emoji | Meaning | Blocking |
|---|---|---|
| ± | Requested change | Yes |
| ❓ | Query (Request for context or explanation) | Yes |
| ❔ | Query (Request for context or explanation) | No |
| 💭 | Note/Question to myself or the @-mentioned user. | No |
| ↔ | "Here's another way to do this:" | No |
| ⬇ | Aesthetic or stylistic quibble | No |
jstvz
changed the title
options read only when using Pydantic option validation
jstvz
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
W-13798912
Made
self.optionsto be Read-Only, if anOptionsclass is defined in the Task. Added usage to documentation. Additionally, correctedListMetadataTypesincumulusci/tasks/util.pyto useparsed_optionsinstead ofoptions(was missed in the pydantic options commit).Fixes: #3627