Cleanup some warnings #3491
Cleanup some warnings #3491
Conversation
prescod
force-pushed
the
cleanup-warnings
branch
from
b9156fd to
70edc91
Compare
.prettierignore
Outdated
There was a problem hiding this comment.
Don't bother prettying Cassettes
| @@ -204,7 +205,15 @@ def user_id(self): | |||
|
|
|||
| @property | |||
| def org_id(self): | |||
| return self.id.split("/")[-2] | |||
| try: | |||
There was a problem hiding this comment.
This code probably relied previously on implicit None for config objects which is evil.
| @@ -254,7 +263,7 @@ def populate_expiration_date(self): | |||
| @property | |||
| def organization_sobject(self): | |||
| """Cached copy of Organization sObject. Does not perform API call.""" | |||
| return self._org_sobject | |||
| return getattr(self, "_org_sobject", None) | |||
There was a problem hiding this comment.
This code probably relied previously on implicit None for config objects which is evil.
| @@ -66,7 +66,7 @@ def test_getattr_toplevel_key_missing(self): | |||
| assert config.foo is None | |||
| with mock.patch( | |||
| "cumulusci.core.config.base_config.STRICT_GETATTR", True | |||
| ), pytest.raises(AssertionError): | |||
| ), pytest.deprecated_call(), pytest.raises(AssertionError): | |||
There was a problem hiding this comment.
Capture a deprecated call.
| @@ -645,6 +645,7 @@ def test_install(self, api_deploy_mock, zip_builder_mock, download_mock): | |||
| assert mock_task.project_config == context | |||
|
|
|||
| api_deploy_mock.return_value.assert_called_once() | |||
| zf.close() | |||
There was a problem hiding this comment.
Close a file explicitly.
| responses.GET, url, match_querystring=True, json=expected_response | ||
| responses.GET, | ||
| url, | ||
| match=[query_string_matcher(query_string)], |
There was a problem hiding this comment.
- Deprecate
match_querystringargument inResponseandCallbackResponse.
Useresponses.matchers.query_param_matcherorresponses.matchers.query_string_matcher
| ) | ||
|
|
||
| def _get_mock_testqueueitem_status_query_url(self, job_id): | ||
| return ( | ||
| self.base_tooling_url | ||
| + f"query/?q=SELECT+Id%2C+Status%2C+ExtendedStatus%2C+ApexClassId+FROM+ApexTestQueueItem+WHERE+ParentJobId+%3D+%27{job_id}%27+AND+Status+%3D+%27Failed%27" | ||
| (self.base_tooling_url + "query/"), |
There was a problem hiding this comment.
Switch to query_string_matcher
| @@ -783,12 +783,11 @@ def test_explicit_channel_declarations(self, mock_load_data, create_task): | |||
| "recipe": Path(__file__).parent | |||
| / "snowfakery/simple_snowfakery.recipe.yml", | |||
| "run_until_recipe_repeated": 15, | |||
| "recipe_options": {"xyzzy": "Nothing happens", "some_number": 42}, | |||
There was a problem hiding this comment.
This was cut and paste from elsewhere and didn't need to be tested over and over.
| @@ -833,7 +832,6 @@ def test_serial_mode(self, mock_load_data, create_task): | |||
| "recipe": Path(__file__).parent | |||
| / "snowfakery/simple_snowfakery.recipe.yml", | |||
| "run_until_recipe_repeated": 15, | |||
| "recipe_options": {"xyzzy": "Nothing happens", "some_number": 42}, | |||
There was a problem hiding this comment.
This was cut and paste from elsewhere and didn't need to be tested over and over.
| @@ -186,7 +186,7 @@ class GithubIssuesParser(IssuesParser): | |||
|
|
|||
| def __new__(cls, release_notes_generator, title, issue_regex=None): | |||
| if not release_notes_generator.has_issues: | |||
| logging.getLogger(__file__).warn( | |||
| logging.getLogger(__file__).warning( | |||
There was a problem hiding this comment.
As of Python 3.3, logger.warn has been deprecated and logger.warning must be used. Even though logger.warn is still backwards compatible, you should not use it.
|
Thanks for the contribution! Unfortunately we can't verify the commit author(s): Paul Prescod <p***@s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, refresh the status of this Pull Request. |
Cleanup a few warnings. I'll use comments to explain.