Jonathan Mules' personal API #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orks, working on update features
Anthony-g2
reviewed
Sep 5, 2017
| console.log('body', req.body); | ||
|
|
||
| // split at comma and remove and trailing space | ||
| var movieTitles = req.body.movieTitles.split(',').map(function(item) { return item.trim(); } ); |
There was a problem hiding this comment.
Try finding a way to seperate the word from the comma's when displaying movie titles.
| console.log(req.body) | ||
| db.Director.findById(req.params._id, function(err, foundDirector) { | ||
|
|
||
| if(err) { console.log(err); } |
mnfmnfm
reviewed
Sep 7, 2017
| app.get('/personal', controllers.personal.index) | ||
| app.get('/director', controllers.director.index) | ||
| app.post('/director', controllers.director.create) | ||
| app.get('/director/:_id', controllers.director.show) |
There was a problem hiding this comment.
Most of the time, we don't put underscores in these URL parameters. (That's just convention though.)
|
|
||
| var DirectorSchema = new Schema({ | ||
| name: String, | ||
| movieTitles: [ String ], |
| console.log('director after POST', director); | ||
| //render the server's response | ||
| }); | ||
| window.location.reload() |
There was a problem hiding this comment.
refreshing the page is the wrong way to display the updated data! I agree with the comment above that you want to render the server's response, not just refresh the page.
|
|
||
| //update director info | ||
| $('.edit-dir-form form').on('submit', function(e) { |
There was a problem hiding this comment.
You run this before the forms are on the page--you need to use event delegation, like you do for the couple of lines above. That's why your edit form is submitting the standard way; this code is never run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.