Carlynn's Personal API #28
Conversation
| }); | ||
|
|
||
|
|
||
| router.get("/", require("./controllers/index")); |
There was a problem hiding this comment.
So much commented out code!! We let it slide the first couple projects but we're going to get nit-pickier about these things moving forward. You should make sure that you're not leaving in console.logs or commented out code.
|
|
||
| }); | ||
|
|
||
| function getVenueHtml(venue) { |
There was a problem hiding this comment.
Make sure you're indenting properly - even when you're writing a template literal string like this! It makes it a lot easier to debug and insures the code is correct when it's appended to your index.html.
| * DATABASE * | ||
| ************/ | ||
|
|
||
| var db = require('./models'); |
There was a problem hiding this comment.
You set up the variable "db" but you never use it...
|
|
||
| // var db = require('./models'); | ||
| var db = require('./models'); | ||
| var venues = db.Venue; |
There was a problem hiding this comment.
Even though you created the variable "venues", you still use db.Venue later in your controller functions so this seems unnecessary.
|
You did a great job Carlynn! Your code looks great - just keep in mind it being cleaner going forward. Other than that the site looks awesome and functions perfectly. |
Boxes on the page shift when you edit a field
If you edit a line or create a new item and it is longer than 2 lines the boxes shift