Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SMBC] update 2411 #672

Merged
merged 33 commits into from
Nov 13, 2024
Merged

[SMBC] update 2411 #672

merged 33 commits into from
Nov 13, 2024

Conversation

sepp4me
Copy link
Member

@sepp4me sepp4me commented Nov 4, 2024

new attributes:

  • showTransportSelectionStrip
  • selectAll
  • frozenColumnCount
  • widthIncludingColumnHeader

new default value for attribute selectionMode: Multi

sepp4me and others added 29 commits August 18, 2024 11:27
@sepp4me
update 2411
75e2f52
@sepp4me @abaplint
Update file-formats/smbc/type/zif_aff_smbc_v1.intf.abap
d52923e 
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@sepp4me @abaplint
Update file-formats/smbc/type/zif_aff_smbc_v1.intf.abap
d319aae 
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@sepp4me @abaplint
Update file-formats/smbc/type/zif_aff_smbc_v1.intf.abap
09b8f5c 
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@sepp4me @abaplint
Update file-formats/smbc/type/zif_aff_smbc_v1.intf.abap
7f08879 
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@sepp4me @abaplint
Update file-formats/smbc/type/zif_aff_smbc_v1.intf.abap
c1e474b 
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@sepp4me @abaplint
Update file-formats/smbc/type/zif_aff_smbc_v1.intf.abap
9ea2f78 
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@sepp4me @abaplint
Update file-formats/smbc/type/zif_aff_smbc_v1.intf.abap
7274da5 
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@sepp4me @abaplint
Update file-formats/smbc/type/zif_aff_smbc_v1.intf.abap
caf0c30 
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@sepp4me @abaplint
Update file-formats/smbc/type/zif_aff_smbc_v1.intf.abap
c8018ce 
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@sepp4me @abaplint
Update file-formats/smbc/type/zif_aff_smbc_v1.intf.abap
39ade4b 
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@sepp4me @abaplint
Update file-formats/smbc/type/zif_aff_smbc_v1.intf.abap
d152706 
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@sepp4me @abaplint
Update file-formats/smbc/type/zif_aff_smbc_v1.intf.abap
198c392 
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@sepp4me @abaplint
Update file-formats/smbc/type/zif_aff_smbc_v1.intf.abap
5d2752b 
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@sepp4me @abaplint
Update file-formats/smbc/type/zif_aff_smbc_v1.intf.abap
3bc04c8 
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@sepp4me @abaplint
Update file-formats/smbc/type/zif_aff_smbc_v1.intf.abap
19dc6bd 
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@sepp4me @abaplint
Update file-formats/smbc/type/zif_aff_smbc_v1.intf.abap
9d7f3ae 
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@sepp4me @abaplint
Update file-formats/smbc/type/zif_aff_smbc_v1.intf.abap
f3d810e 
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@sepp4me @abaplint
Update file-formats/smbc/type/zif_aff_smbc_v1.intf.abap
cec6b6a 
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@sepp4me @abaplint
Update file-formats/smbc/type/zif_aff_smbc_v1.intf.abap
66b2eb3 
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@sepp4me @abaplint
Update file-formats/smbc/type/zif_aff_smbc_v1.intf.abap
72aaad2 
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@sepp4me @abaplint
Update file-formats/smbc/type/zif_aff_smbc_v1.intf.abap
fe7a00a 
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@sepp4me @abaplint
Update file-formats/smbc/type/zif_aff_smbc_v1.intf.abap
3f9d152 
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@sepp4me @abaplint
Update file-formats/smbc/type/zif_aff_smbc_v1.intf.abap
874d5d7 
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@sepp4me @abaplint
Update file-formats/smbc/type/zif_aff_smbc_v1.intf.abap
9f06c61 
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@sepp4me @abaplint
Update file-formats/smbc/type/zif_aff_smbc_v1.intf.abap
6031bf1 
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@sepp4me @abaplint
Update file-formats/smbc/type/zif_aff_smbc_v1.intf.abap
e759dee 
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@sepp4me @abaplint
Update file-formats/smbc/type/zif_aff_smbc_v1.intf.abap
2d50772 
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@schneidermic0
Merge branch 'main' into main
5cbf251
schneidermic0
schneidermic0 requested changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sepp4me Thanks for sharing the update.
Sorry for the late review. I didn't manage to look into it earlier.

We need to discuss the change of the default value. From my point of view this is an incompatible change which could be covered by a new format version if needed.

Please also fix the ABAP lint issue

file-formats/smbc/type/zif_aff_smbc_v1.intf.abap Outdated
"! You can freeze the first columns of a table so that they always remain visible when scrolling the table horizontally
"! $minimum 0
"! $maximum 30
"! $default '0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: I guess no default would be needed since 0 is automatically the default value for integers.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ABAP lint and default value -> done

file-formats/smbc/type/zif_aff_smbc_v1.intf.abap Show resolved Hide resolved
schneidermic0
schneidermic0 approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks good to me. I am adding UX colleagues.

I see only a mismatch of a field name with its title. But due to length restrictions I also didn't come up with a better proposal

file-formats/smbc/type/zif_aff_smbc_v1.intf.abap Outdated Show resolved Hide resolved
@schneidermic0 schneidermic0 added the ux-review ready AFF is ready for UX review label Nov 11, 2024
wurzka
wurzka requested changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@wurzka wurzka left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one issue with the title, apart from that it looks good to me.

file-formats/smbc/type/zif_aff_smbc_v1.intf.abap Outdated Show resolved Hide resolved
wurzka
wurzka approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@wurzka wurzka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me from UX perspective

@wurzka
Copy link
Contributor

wurzka commented Nov 13, 2024

As changing the default from "auto" to "multi" is (semantically) a compatible change (see discussion), we can merge this change without increasing the format version.

@wurzka wurzka merged commit 7121594 into SAP:main Nov 13, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wurzka wurzka wurzka approved these changes

@schneidermic0 schneidermic0 schneidermic0 approved these changes

Assignees
No one assigned
Labels
ux-review ready AFF is ready for UX review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sepp4me @wurzka @schneidermic0