-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sockopts: support many more socket options, including strings #514
Open
robbat2
wants to merge
1
commit into
RsyncProject:master
Choose a base branch
from
robbat2:sockopts
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbat2
force-pushed
the
sockopts
branch
4 times, most recently
from
August 20, 2023 23:53
2f9a1e9
to
073a65d
Compare
maintainer:
|
Flameeyes
reviewed
Aug 21, 2023
robbat2
force-pushed
the
sockopts
branch
2 times, most recently
from
August 21, 2023 20:21
8a110d1
to
78357b0
Compare
@WayneD this is ready for your review |
@robbat2 needs a rebase |
@tridge rebased now; only conflict was in |
@tridge rebased again if you could merge please? |
Add support for many more socket options, including those that take string inputs, such as `TCP_CONGESTION=bbr`. Options known to the code, but not present at build time will now emit an error that is distict from options unknown to the code (unknown vs not-available). This patch greatly eases running specific rsync configurations, without relying on LD_PRELOAD to modify socket behaviors. Signed-off-by: Robin H. Johnson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for many more socket options, including those that take string inputs, such as
TCP_CONGESTION=bbr
.Options known to the code, but not present at build time will now emit an error that is distict from options unknown to the code (unknown vs not-available).
This patch greatly eases running specific rsync configurations, without relying on LD_PRELOAD to modify socket behaviors.