fix: correct delete messages permission behavior in Administration #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Title
Resolve Delete permission behaviour in Administration
Acceptance Criteria fulfillment
Ensure normal users cannot see the delete icon when
deleteOwnMessageis set to false by adminAlign permission behaviour with the hierarchy:
1.
forcedeletemessage2.
deletemessage3.
deleteOwnMessageFix visibility inconsistencies in delete icon functionality.
Fixes #749
Video/Screenshots
Permissions.-.Singha.-.Brave.2024-12-29.13-48-15.mp4
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-752 after approval. Contributors are requested to replace
<pr_number>with the actual PR number.