Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: permission issues for video and audio message #730

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

abirc8010
Copy link
Contributor

@abirc8010 abirc8010 commented Dec 24, 2024

Brief Title

Prevent audio icon from changing its state and video icon to display modal if permissions are not granated and display an error toastbar message

Acceptance Criteria fulfillment

  • Ensure the recorder does not start without microphone or camera permissions.
  • Display an error message via the toast bar when permissions are missing.
  • Prevent the recording state from changing if permissions are denied.

Fixes #729

Video/Screenshots

Screencast.from.2024-12-24.17-38-01.webm

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-730 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@smritidoneria
Copy link
Contributor

hey @abirc8010 ,I believe that prompting the user to grant permissions might provide a better user experience. By proactively guiding users to enable the necessary permissions, we can prevent confusion and make the process more seamless. Instead of just showing an error message, prompting users to grant permissions directly can help ensure they understand the action needed to proceed.

your thoughts @Spiral-Memory ?

@Spiral-Memory
Copy link
Collaborator

@smritidoneria
You are right !
Let's prompt user to enable the permission and then we can start the recording

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audio and video messages changes state even if necessary permissions are not granted
3 participants