Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed all markdown issues #614

Merged
merged 13 commits into from
Dec 22, 2024
Merged

fixed all markdown issues #614

merged 13 commits into from
Dec 22, 2024

Conversation

smritidoneria
Copy link
Contributor

Brief Title

Fixed all the message rendering issues.

Acceptance Criteria fulfillment

  • Task 1
  • Task 2
  • Task 3

Fixes #613

Video/Screenshots

Screen.Recording.2024-07-26.at.2.04.40.AM.mov

@devanshkansagra
Copy link
Contributor

@smritidoneria, Could you please check and share the result of strikethrough and other markdowns whether it is working or not when the quoted message is sent? When I saw your code, you have made no changes in attachment preview dir. So I think at that point there could be this small bug

@smritidoneria
Copy link
Contributor Author

hey @devanshkansagra , thanks for pointing out, I will look after it

@Spiral-Memory
Copy link
Collaborator

Hey @smritidoneria
Could you please resolve the conflicts?

@smritidoneria smritidoneria marked this pull request as draft October 22, 2024 10:06
@smritidoneria smritidoneria marked this pull request as ready for review October 22, 2024 14:12
@smritidoneria
Copy link
Contributor Author

hey @Spiral-Memory , changes have been made to resolve the conflicts, kindly look at it.

@Spiral-Memory
Copy link
Collaborator

Format check is failing @smritidoneria

@smritidoneria
Copy link
Contributor Author

hey @Spiral-Memory , Something is wrong with the built
SyntaxError: Unexpected identifier 'assert'
at compileSourceTextModule (node:internal/modules/esm/utils:337:16)
at ModuleLoader.moduleStrategy (node:internal/modules/esm/translators:166:18)
at callTranslator (node:internal/modules/esm/loader:416:14)
at ModuleLoader.moduleProvider (node:internal/modules/esm/loader:422:30)
at link (node:internal/modules/esm/module_job:88:21)

This error is coming,

I have ran prettier, installed babel for the Transpilation also , but it remains the same.

@Spiral-Memory
Copy link
Collaborator

Hey @smritidoneria,

It's working for all new PRs except yours. Could you please check if there's any issue with your setup?

If the problem still exists, I'll clone your code and investigate what might be causing it.

@smritidoneria
Copy link
Contributor Author

can u re-run the checks, I have resolved the errors @Spiral-Memory

@Spiral-Memory
Copy link
Collaborator

Format check passed, lint check failing

@smritidoneria
Copy link
Contributor Author

fixed.

@Spiral-Memory
Copy link
Collaborator

Can you please list all the places you fixed the markdown ? I need to verify

@smritidoneria
Copy link
Contributor Author

while quoting messages and in the delete modal.

Spiral-Memory
Spiral-Memory reviewed Nov 10, 2024
View reviewed changes
Copy link
Collaborator

@Spiral-Memory Spiral-Memory left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smritidoneria requesting you to look at the req changes.

Spiral-Memory
Spiral-Memory reviewed Nov 10, 2024
View reviewed changes
packages/react/src/views/ChatInput/ChatInput.js Outdated
@@ -155,7 +156,7 @@ const ChatInput = ({ scrollToBottom }) => {
messageRef.current.value =
editMessage.attachments[0]?.description || editMessage.msg;
} else if (editMessage.msg) {
messageRef.current.value = editMessage.msg;
messageRef.current.value = <Markdown body={editMessage} />;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@smritidoneria
Copy link
Contributor Author

hey @Spiral-Memory , resolved the changes that you have mentioned. kindly look into it.

Spiral-Memory
Spiral-Memory reviewed Dec 17, 2024
View reviewed changes
packages/react/src/views/QuoteMessage/QuoteMessage.js Outdated
@@ -53,62 +54,13 @@ const QuoteMessage = ({ className = '', style = {}, message }) => {
<Box>{format(new Date(message.ts), 'h:mm a')}</Box>
</Box>
<Box css={styles.message}>
{message.file ? (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any specific reason, you are removing these ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, I mistakenly removed the code

Spiral-Memory
Spiral-Memory reviewed Dec 22, 2024
View reviewed changes
packages/react/src/views/ChatHeader/ChatHeader.js Outdated
@@ -389,6 +389,7 @@ const ChatHeader = ({
</Box>
{isThreadOpen && (
<DynamicHeader
Markdown
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smritidoneria
Why is Markdown written here ? Looks invalid

@Spiral-Memory Spiral-Memory merged commit 0d7ff8d into RocketChat:develop Dec 22, 2024
3 checks passed
github-actions bot added a commit that referenced this pull request Dec 22, 2024
@github-actions
Remove deployment for PR #614
3c97071
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Spiral-Memory Spiral-Memory Spiral-Memory approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

All markdown issues
3 participants
@smritidoneria @devanshkansagra @Spiral-Memory