Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for ROS2ScriptIntegration #63

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

jhanca-robotecai
Copy link
Contributor

@jhanca-robotecai jhanca-robotecai commented Sep 16, 2024

There ROS2ScriptIntegration:

  1. One topic with the typo was renamed to keep the convention
  2. cmake was fixed

Ad 2.
I tried to use this package when building a monolithic build on Ubuntu 2404 but I got the following error:

[INFO] root: Running process 'cmake' with PID(6933): ['cmake', '--build', PosixPath('/home/jhanca/devroot/projects/FlasheyeCraneSensors/build/tools'), '--config', 'profile', '--target', 'AssetProcessorBatch', 'AssetBundlerBatch']
[INFO] root: ninja: error: 'External/ROS2ScriptIntegration-bc386a44/Code/CMakeFiles/ROS2ScriptIntegration.Private.Object.dir/profile/Source/ROS2ScriptIntegrationModuleInterface.cpp.o', needed by 'bin/profile/libROS2ScriptIntegration.Editor.so', missing and no known rule to make it

This PR fixes it.

@jhanca-robotecai jhanca-robotecai merged commit 288a29c into main Sep 17, 2024
1 check passed
@jhanca-robotecai jhanca-robotecai deleted the jh/update_cmake_ROS2Integration branch September 17, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants