Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pointcloud] Adding busses for easier better editor UX #57

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

Fireronin
Copy link
Contributor

Resolves #53

Right now first two are implemented
AzFramework::BoundsRequestBus
AzToolsFramework::EditorComponentSelectionRequestsBus

@michalpelka
Copy link
Collaborator

Please give a meaningful name to PR.

@Fireronin Fireronin changed the title Kr/adding busses [Pointcloud] Adding busses for easier better editor UX Aug 19, 2024
@Fireronin Fireronin marked this pull request as ready for review August 22, 2024 12:39
@Fireronin
Copy link
Contributor Author

I did a bit of testing and cleaned up changed files

@Fireronin Fireronin requested a review from michalpelka August 29, 2024 08:39
Copy link
Member

@zakmat zakmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yesterday I worked with the code a little since there were some issues with the version I reviewed. I have reapplied some changes on top of yours. A final solution is satisfactory. Thanks a lot!

Copy link
Collaborator

@michalpelka michalpelka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code cannot be compiled with 2409.
In 2409 API for :

        AZ::Aabb GetWorldBounds() const override;
        AZ::Aabb GetLocalBounds() const override;

Some methods have are const . In 2310 not.
Except that it works nicely.

@michalpelka
Copy link
Collaborator

I think that is not a blocker to merge. Those gems should work with release version of o3de that currently is 2309.

@zakmat zakmat merged commit 1889b03 into main Aug 29, 2024
1 check passed
@zakmat zakmat deleted the kr/Adding-busses branch August 29, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Pointcloud] Add some useful Editor Buses
3 participants