-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pointcloud] Adding busses for easier better editor UX #57
Conversation
Please give a meaningful name to PR. |
9426763
to
7dce2be
Compare
7dce2be
to
1b8ff5a
Compare
1b8ff5a
to
e5bef7b
Compare
I did a bit of testing and cleaned up changed files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yesterday I worked with the code a little since there were some issues with the version I reviewed. I have reapplied some changes on top of yours. A final solution is satisfactory. Thanks a lot!
Signed-off-by: Mateusz Żak <[email protected]>
4a2e826
to
fa46ce2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code cannot be compiled with 2409.
In 2409 API for :
AZ::Aabb GetWorldBounds() const override;
AZ::Aabb GetLocalBounds() const override;
Some methods have are const . In 2310 not.
Except that it works nicely.
I think that is not a blocker to merge. Those gems should work with release version of o3de that currently is 2309. |
Resolves #53
Right now first two are implemented
AzFramework::BoundsRequestBus
AzToolsFramework::EditorComponentSelectionRequestsBus