Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild January 2025 - switch to rattler-build #229

Open
wants to merge 113 commits into
base: main
Choose a base branch
from

Conversation

traversaro
Copy link
Member

@traversaro traversaro commented Dec 17, 2024

Full rebuild on all platforms, heavily based on:

List of PRs and issues that will be fixed once this PR is merged:

@Tobias-Fischer
Copy link
Contributor

@traversaro
Copy link
Member Author

I think we need a NOMINMAX: https://github.com/ros2/rclcpp/blob/19773973a80d753c6fa028b0b548462fbbef122d/rclcpp/include/rclcpp/duration.hpp#L104C3-L104C6

As long as you do not include Windows.h (like avt_vimba does) you do not need the NOMINMAX, and given how problematic Windows.h is, I guess it should be downstream users of both Windows.h and rclcpp that need to define it. However, for this specific problem of avt_vimba_camera I think we can skip to speed up the rebuild, nobody ever asked for it on windows and I only added it on Windows as I uniformed the linux and windows vinca files.

@mora200217
Copy link

This will fix the ros2-distro-mutex=0.5 version error ?

@traversaro
Copy link
Member Author

This will fix the ros2-distro-mutex=0.5 version error ?

Which error?

@Tobias-Fischer
Copy link
Contributor

We should unvendor gtsam, see RoboStack/ros-noetic@f1a5f29

@mora200217
Copy link

Which error?

@traversaro When trying to install pkgs like ros-humble-ros2-controllers says that it requires ros2-distro-mutex=0.5. When trying to update, says that there is only ros-humble-desktop build for 0.3 version.

Pinned packages:
  - python 3.10.*

Could not solve for environment specs
Encountered problems while solving:
  - package ros-humble-ros2-controllers-2.32.0-py311h907a76e_5 requires ros2-distro-mutex 0.5.*, but none of the providers can be installed

The environment can't be solved, aborting the operation

Environment specs:

  • OS: Macos Sonoma
  • Distro: humble
  • Python: 3.10

@Tobias-Fischer
Copy link
Contributor

@mora200217 - you need to use a fresh environment with python=3.11 as that's the only supported Python version in recent RoboStack builds.

@Tobias-Fischer
Copy link
Contributor

Tobias-Fischer commented Jan 4, 2025

Hmm it seems like the updated version of https://github.com/traversaro/ros-humble/blob/rebuild-christmas-2024-linux-64-rattler-build/patch/ros-humble-rosx-introspection.patch doesn't apply cleanly on osx - could you please take a look @traversaro?

2025-01-04T03:41:58.2457790Z  │ ╭─ Fetching source code
2025-01-04T03:41:58.2458180Z  │ │ Fetching source from git repo: https://github.com/ros2-gbp/rosx_introspection-release.git
2025-01-04T03:41:58.9819540Z  │ │ Fetching repository from https://github.com/ros2-gbp/rosx_introspection-release.git at refs/tags/release/humble/rosx_introspection/1.0.2-2 into /Users/runn
2025-01-04T03:41:58.9820290Z  │ │ er/work/ros-humble/ros-humble/output/src_cache/rosx_introspection-release.git
2025-01-04T03:41:59.7231440Z  │ │ Checked out revision: 'refs/tags/release/humble/rosx_introspection/1.0.2-2' at '0cc0f63428c7ce410700ef79cf00c01a266fd09a'
2025-01-04T03:41:59.7455010Z  │ │ Copied 71 files into isolated environment
2025-01-04T03:41:59.8103450Z  │ │ × error Failed to apply patch: /Users/runner/work/ros-humble/ros-humble/recipes/ros-humble-rosx-introspection/patch/ros-humble-rosx-introspection.patch
2025-01-04T03:41:59.8107980Z  │ │ × error Stdout: patching file 'src/ros_parser.cpp'
2025-01-04T03:41:59.8238600Z  │ │ × error patching file 'src/ros_utils/message_definition_cache.cpp'
2025-01-04T03:41:59.8346080Z  │ │ × error 1 out of 1 hunks failed--saving rejects to 'src/ros_utils/message_definition_cache.cpp.rej'
2025-01-04T03:41:59.8577350Z  │ │ × error patching file CMakeLists.txt
2025-01-04T03:41:59.8678540Z  │ │ × error 1 out of 1 hunks failed--saving rejects to CMakeLists.txt.rej
2025-01-04T03:41:59.8779660Z  │ │ × error Stderr: 

@traversaro
Copy link
Member Author

We can probably make the patch windows only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants