BSI library expanded to include support for large arbitrary values via the big.Int library #451
+469
−110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemire
reviewed
Oct 23, 2024
|
@guymolinari Can you have a look at our failing tests? |
|
Looking.....
…On Wed, Oct 23, 2024 at 12:33 PM Daniel Lemire ***@***.***> wrote:
@guymolinari <https://github.com/guymolinari> Can you have a look at our
failing tests?
—
Reply to this email directly, view it on GitHub
<#451 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADZZAUVZ45INXI6QGBMBA23Z47TYTAVCNFSM6AAAAABQPMBCZOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZTGEZTCOJSGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Daniel. Would it be possible to update the environment to use at least go 1.15? |
Absolutely. Maybe it would be cleaner to do it with a separate PR. We could push the required version up, and then handle this PR. |
|
Daniel. Missed your last message. I think I have it sorted out now. |
|
Let us merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no fundamental reason why the BSI library cannot support values exceeding 64 bits. Why is this necessary? It would now be possible to store values like UUID and 96 bit timestamps, as well as advanced string encodings in a BSI.
The BSI library has been modified to preserve the existing int64 interface and has been expanded to leverage the golang big.Int math library. The original int64 methods now convert incoming values to *big.Int (and vice versa, etc).
Additional test coverage has been added and some of the original tests have been expanded.
Performance does not seem to be substantially impacted.