Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deserialize Run Containers #255

Merged
merged 3 commits into from
Jul 10, 2023
Merged

Deserialize Run Containers #255

merged 3 commits into from
Jul 10, 2023

Conversation

Kerollmops
Copy link
Member

@Kerollmops Kerollmops commented Jul 7, 2023

This PR is related to #12 and #66 because it allows anyone to support run containers when deserializing roaring bitmaps and treemaps. Note that it doesn't support run container operations as run containers are converted into array or bitmap containers depending on the total cardinality of the ranges run.

Copy link
Contributor

@josephglanville josephglanville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kerollmops
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jul 8, 2023
@bors
Copy link
Contributor

bors bot commented Jul 8, 2023

try

Build failed:

@Kerollmops Kerollmops force-pushed the deserialize-run-containers branch 3 times, most recently from 0ed2cf5 to 598093f Compare July 9, 2023 11:41
@Kerollmops Kerollmops force-pushed the deserialize-run-containers branch from 598093f to 95664bd Compare July 9, 2023 11:41
@Kerollmops Kerollmops merged commit 6aabe69 into main Jul 10, 2023
@Kerollmops Kerollmops deleted the deserialize-run-containers branch July 10, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants