feat: auto apply checksum when starting VSCode #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Iewnfod <[email protected]>
RimuruChan
requested changes
Dec 6, 2024
src/extension.js
Outdated
| @@ -17,6 +17,9 @@ exports.activate = function activate(context) { | |||
| vscode.commands.registerCommand('fixChecksums.restore', restore) | |||
| ) | |||
| cleanupOrigFiles() | |||
|
|
|||
| const auto = vscode.workspace.getConfiguration().get("checksums.autoFix") | |||
| apply(auto) | |||
There was a problem hiding this comment.
Seems that it always applies whether you set auto fix or not. The option just hides the message, not controls the behavior
There was a problem hiding this comment.
Yes, seems auto only controls message, then the logic should be correct with a if clause.
However, the plugin code doesn't load with VSCode extension server starting, but on the first command was executed, thus the function call apply(auto) seems no sense.
Or shall we set the plugin activate on start up to trigger an Apply event?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto apply feature from iewnfod/vscode-fix-checksums