Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses Valgrind for ExperimentalMemCheck in ctest #844

Merged

Conversation

weslleyspereira
Copy link
Collaborator

@weslleyspereira weslleyspereira commented May 30, 2023

Uses valgrind if it is available.

TO-DO

  • Try to optimize the runs with Valgrind. The test is currently taking too much time to complete.

@weslleyspereira weslleyspereira force-pushed the try-valgrind branch 2 times, most recently from 9e70645 to 610d314 Compare May 30, 2023 16:59
@weslleyspereira
Copy link
Collaborator Author

Related to #551 (comment)

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (33b3a45) 0.00% compared to head (7ebfd17) 0.00%.
Report is 2 commits behind head on master.

❗ Current head 7ebfd17 differs from pull request most recent head cfe1114. Consider uploading reports for the commit cfe1114 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #844   +/-   ##
=======================================
  Coverage    0.00%    0.00%           
=======================================
  Files        1918     1918           
  Lines      188645   188645           
=======================================
  Misses     188645   188645           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weslleyspereira
Copy link
Collaborator Author

I believe this is also related to #790.

@weslleyspereira
Copy link
Collaborator Author

Related to #911 and #790.

@weslleyspereira
Copy link
Collaborator Author

Valgrind seems to be working great with LAPACK now. It has found 2 possible memory leaks in example_DGESV_colmajor and example_DGESV_rowmajor. I am taking a look at those.

@weslleyspereira weslleyspereira marked this pull request as ready for review November 1, 2023 15:09
langou
langou previously approved these changes Nov 1, 2023
@langou
Copy link
Contributor

langou commented Nov 1, 2023

Wow! That's amazing. Thanks @weslleyspereira !

@weslleyspereira weslleyspereira marked this pull request as ready for review November 1, 2023 17:03
@weslleyspereira
Copy link
Collaborator Author

It should be ready for merge.

There are some spurious defects found in by Valgrind only when used in the Github CI. I am not sure where they come from.

  1. no information is provided in the MemoryCheck files.
  2. I can't reproduce it locally.

So, I opt for ignoring those defects in the CI for now.

@weslleyspereira weslleyspereira merged commit e18529f into Reference-LAPACK:master Nov 1, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants