-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uses Valgrind for ExperimentalMemCheck in ctest #844
Uses Valgrind for ExperimentalMemCheck in ctest #844
Conversation
9e70645
to
610d314
Compare
Related to #551 (comment) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #844 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 1918 1918
Lines 188645 188645
=======================================
Misses 188645 188645 ☔ View full report in Codecov by Sentry. |
I believe this is also related to #790. |
91c9176
to
833ae88
Compare
Valgrind seems to be working great with LAPACK now. It has found 2 possible memory leaks in example_DGESV_colmajor and example_DGESV_rowmajor. I am taking a look at those. |
Wow! That's amazing. Thanks @weslleyspereira ! |
e48f438
to
c04d7fc
Compare
c04d7fc
to
cfe1114
Compare
It should be ready for merge. There are some spurious defects found in by Valgrind only when used in the Github CI. I am not sure where they come from.
So, I opt for ignoring those defects in the CI for now. |
Uses valgrind if it is available.
TO-DO