Remove comparison as these conditions are never true #1062
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The problem is that dtpmqrt is impossible to use because
side
must be eitherl
(L
) orr
(R
). The condition not only usesLAPACKE_lsame
to compare against the possible values, but also compare the boolean result againstside
(which is achar
). This situation ultimately leads to a logical expression that will never be true, making it impossible to usedtpmqrt
and others routines affected by similar code. The commit simply removesside ==
as this fix the problem.Checklist