Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove comparison as these conditions are never true #1062

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

schnorr
Copy link
Contributor

@schnorr schnorr commented Oct 12, 2024

Description
The problem is that dtpmqrt is impossible to use because side must be either l (L) or r (R). The condition not only uses LAPACKE_lsame to compare against the possible values, but also compare the boolean result against side (which is a char). This situation ultimately leads to a logical expression that will never be true, making it impossible to use dtpmqrt and others routines affected by similar code. The commit simply removes side == as this fix the problem.

Checklist

  • The documentation has been updated.
    • No documentation change required as in previous version it was OK
  • If the PR solves a specific issue, it is set to be closed on merge.
    • No issues found describing this problem

@martin-frbg
Copy link
Collaborator

looks like these comparisons came in with #540 @weslleyspereira

@langou langou merged commit 6061809 into Reference-LAPACK:master Oct 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants