Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/CD Step for Service Init #200

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

saltgen
Copy link
Contributor

@saltgen saltgen commented Apr 2, 2024

Why do we need this change? 💭

CI/CD Step for Service Init to ensure ROS starts up fine

Documentation update? 📝

  • Yes
  • No

Security Checklist 🔒

Upon raising this PR please go through RedHatInsights/secure-coding-checklist

💂‍♂️ Checklist 🎯

  • Does this change depend on specific version of Kruize
    • If yes what is the version no:
    • Is that image available in production or needs deployment?
  • Bugfix
  • New Feature
  • Refactor
  • Unittests Added
  • DRY code
  • Dependency Added
  • DB Migration Added

Additional 📣

Feel free to add any other relevant details such as links, notes, screenshots, here.

@saltgen
Copy link
Contributor Author

saltgen commented Apr 2, 2024

/retest

@upadhyeammit
Copy link
Contributor

As we are checking if specific module can be run then should we also check for recommendation poller and api and even sources?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants