-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added podman scripts #128
base: master
Are you sure you want to change the base?
Added podman scripts #128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the initiative, @Victoremepunto! A couple comments so far inline.
|
||
PODMAN_NETWORK="cni-podman1" | ||
PODMAN_GATEWAY=$(podman network inspect $PODMAN_NETWORK | jq -r '..| .gateway? // empty') | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$RUNNER network inspect $PODMAN_NETWORK &>/dev/null || $RUNNER network create $PODMAN_NETWORK | |
#!/usr/bin/env bash | ||
|
||
set -e | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd be useful (to me, at least) to have a $RUNNER
env variable, defaulted to podman
:
RUNNER=${RUNNER:podman} | |
Then, for example, you can invoke the script like this:
RUNNER='sudo podman' ./scripts/podman-bootstrap.sh
How have you been running it? With sudo ./scripts/podman-bootstrap.sh
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeh exactly, as this version needs to manipulate networks and at the moment podman
requires sudo
privileges for it. not sure I want to keep it that way, but one of the things we will be dropping if going for rootless podman containers is dns domain name resolution
. the alternative in rootless podman would be to keep all services inside the same pod, and listen to localhost:{service-port} when communicating with other containers.
Take a look at the shellcheck output on these scripts. There are a few suggestions worth fixing.
|
This is still a WIP
Provides Podman based bash scripts and pod.yaml template to deploy locally the Ingress service stack using podman.