Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add login to Openshift cluster logic #45

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Add login to Openshift cluster logic #45

merged 3 commits into from
Jan 10, 2024

Conversation

Victoremepunto
Copy link
Contributor

@Victoremepunto Victoremepunto commented Jan 10, 2024 •
edited
Loading

This PR provides a proper error message when credentials are not found when attempting to log into a cluster

Now the output in case all login attempt are unsuccessful should look like this

OC_LOGIN_SERVER=foo OC_LOGIN_TOKEN=bar source bootstrap.sh 
error: dial tcp: lookup foo: no such host - verify you have provided the correct host and port and that the server is currently running.
Failed logging into cluster: 'ephemeral'
Environment variables for cluster 'crcd' not found
Failed logging into any cluster!

@Victoremepunto Victoremepunto marked this pull request as draft January 10, 2024 10:21
@Victoremepunto Victoremepunto marked this pull request as ready for review January 10, 2024 10:53
@Victoremepunto Victoremepunto merged commit 344ecf2 into RedHatInsights:main Jan 10, 2024
3 checks passed
@Victoremepunto Victoremepunto deleted the add-support-new-ephemeral branch January 10, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gburges gburges gburges approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Victoremepunto @gburges