Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure JUnit tests pass #30

Merged
merged 12 commits into from
Oct 26, 2023
Merged

Conversation

mjholder
Copy link
Contributor

Ticket: https://issues.redhat.com/browse/RHCLOUD-28568
This PR makes sure the Junit tests pass by checking the artifacts exist.

@mjholder mjholder marked this pull request as ready for review October 18, 2023 11:49
@mjholder mjholder marked this pull request as draft October 18, 2023 12:31
@mjholder mjholder marked this pull request as ready for review October 18, 2023 13:07
@gburges
Copy link
Contributor

gburges commented Oct 18, 2023

/lgtm

cji_smoke_test.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@Victoremepunto Victoremepunto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a comment to RHCLOUD-28568, I believe this should be handled at pipeline level, with a JUnit reporter instead.

Can we please consider this instead?

@Victoremepunto Victoremepunto self-requested a review October 18, 2023 19:59
cji_smoke_test.sh Outdated Show resolved Hide resolved
@bsquizz bsquizz merged commit e3fe8f0 into RedHatInsights:main Oct 26, 2023
3 checks passed
@gburges
Copy link
Contributor

gburges commented Oct 27, 2023

reverting because iqe_runner.sh uses $plugin to construct the filename but the cji_smoke_test.sh relies on $CJI_NAME and that doesn't always match

gburges added a commit that referenced this pull request Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants