Add the option to change bonfire reservation duration #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure who to ask for review, @Victoremepunto could you maybe review? |
Victoremepunto
requested changes
Oct 16, 2023
| @@ -16,7 +16,7 @@ source ${CICD_ROOT}/_common_deploy_logic.sh | |||
| # -> use this PR as the template ref when downloading configurations for this component | |||
| # -> use this PR's newly built image in the deployed configurations | |||
| set -x | |||
| export NAMESPACE=$(bonfire namespace reserve --pool ${NAMESPACE_POOL}) | |||
There was a problem hiding this comment.
if we want to add this feature, let's try follow the same approach (and syntax) for other global vars , see for example, line 13:
# Whether or not to deploy frontends (default: false)
: ${DEPLOY_FRONTENDS:="false"}
so something like a comment, a default value, then just use it on line 19
Also would tag @bsquizz here for review too ^
There was a problem hiding this comment.
I agree, good suggestion @Victoremepunto -- having all the "options" defined up top is preferred for readability.
There was a problem hiding this comment.
Yeah sorry I just basically copied the same change I made in Gitlab includes. Now it looks more like the rest.
jrusz
force-pushed
the
bonfire-reservation
branch
from
7ccc703 to
ffd396a
Compare
Victoremepunto
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes our
pr_checkcan take over an hour so we need the option to reserve the namespace for longer.