Fix Shellcheck tips

src/load_module.sh

@@ -2,12 +2,14 @@
 
 # https://stackoverflow.com/a/246128
 if [ -z "$CICD_LOADER_SCRIPTS_DIR" ]; then
-    readonly CICD_LOADER_SCRIPTS_DIR="$(cd -- "$(dirname -- "${BASH_SOURCE[0]}")" &> /dev/null && pwd)"
+  CICD_LOADER_SCRIPTS_DIR="$(cd -- "$(dirname -- "${BASH_SOURCE[0]}")" &>/dev/null && pwd)"
 fi
 
+readonly CICD_LOADER_SCRIPTS_DIR
+
 if ! source "${CICD_LOADER_SCRIPTS_DIR}/shared/loader.sh"; then
-    echo "Error loading 'loader' module!"
-    exit 1
+  echo "Error loading 'loader' module!"
+  exit 1
 fi
 
 # TODO: undo all loader module stuff

src/shared/common.sh

@@ -1,3 +1,5 @@
+#!/bin/bash
+
 # Common functions that are shared across the different modules
 
 if [[ -n "$CICD_COMMON_MODULE_LOADED" ]]; then

src/shared/container.sh

@@ -1,3 +1,5 @@
+#!/bin/bash
+
 # container engine helper functions to handle both podman and docker commands
 
 if [[ -n "$CICD_CONTAINER_MODULE_LOADED" ]]; then

src/shared/image_builder.sh

@@ -1,3 +1,5 @@
+#!/bin/bash
+
 # helper functions to build container images
 
 if [[ -n "$CICD_IMAGE_BUILDER_MODULE_LOADED" ]]; then

src/shared/loader.sh

@@ -1,3 +1,7 @@
+#!/bin/bash
+
+# Internal module to provide module loading helper functions
+
 CICD_LOADER_MODULE_LOADED=${CICD_LOADER_MODULE_LOADED:-1}
 
 if [[ "$CICD_LOADER_MODULE_LOADED" -eq 0 ]]; then
@@ -11,6 +15,7 @@ if [[ -z "$CICD_LOADER_SCRIPTS_DIR" ]]; then
   return 1
 fi
 
+# shellcheck source=src/shared/log.sh
 if ! source "${CICD_LOADER_SCRIPTS_DIR}/shared/log.sh"; then
   echo "Error loading 'log' module!"
   return 1
@@ -44,7 +49,7 @@ cicd::loader::_load_all() {
 }
 
 cicd::loader::_load_log_module() {
-  # shellcheck source=src/shared/common.sh
+  # shellcheck source=src/shared/log.sh
   source "${CICD_LOADER_SCRIPTS_DIR}/shared/log.sh"
 }
 

src/shared/log.sh

@@ -1,3 +1,7 @@
+#!/bin/bash
+
+# logging helper funtions
+
 CICD_LOG_DEBUG=${CICD_LOG_DEBUG:-}
 
 if [[ -n "$CICD_LOG_MODULE_LOADED" ]]; then