Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/descriptionexample #225

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

dscervantes
Copy link
Contributor

Adding Descriptions and example for the properties

RHCLOUD-26190

@dscervantes
Copy link
Contributor Author

image

@josejulio
Copy link
Member

josejulio commented Sep 19, 2023

@dscervantes could you show us an example with a response type other than a string?

@dscervantes
Copy link
Contributor Author

Hm, maybe I am confused about the ask? all of the ones that are in example tag in content.json are "strings" or "integers", since its the developers adding example strings.

@josejulio
Copy link
Member

Hm, maybe I am confused about the ask? all of the ones that are in example tag in content.json are "strings" or "integers", since its the developers adding example strings.

mmmh probably - i also didn't saw the example in full detail 🤔

@josejulio
Copy link
Member

josejulio commented Sep 20, 2023

To clarify, i think that showing an example per-attribute feels off, as you don't have the big picture or something that you could quickly copy and paste.

I would expect something like this (excuse my rustic terrible drawings)

image

This is similar to what we have now on each request response- It's on the advisor's API

image

@tahmidefaz @dscervantes what do you think?

@dscervantes
Copy link
Contributor Author

OH! That makes total sense! So not each attribute but an example for each object and their attributes ? Let me change the ticket to reflect this ! Let me know if that is what we want as a final result!

@tahmidefaz
Copy link
Member

To clarify, i think that showing an example per-attribute feels off, as you don't have the big picture or something that you could quickly copy and paste.

I would expect something like this (excuse my rustic terrible drawings)

image

This is similar to what we have now on each request response- It's on the advisor's API

image

@tahmidefaz @dscervantes what do you think?

Yep, that makes sense to me. Let's do it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants