Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable covr (temporarily) #6122

Merged
merged 1 commit into from
May 3, 2024
Merged

Disable covr (temporarily) #6122

merged 1 commit into from
May 3, 2024

Conversation

MichaelChirico
Copy link
Member

{covr} has been segfaulting; I reported this upstream at:

r-lib/covr#567

It's no use having a CI item that just fails every time, so disabling it for now. Please chime in on #6117 with ideas of how to debug if you have any.

cc @tdhock @jangorecki. Merging now, but please keep in mind to be extra diligent on PR test coverage in the meantime since we don't have the automation to back up on. It probably makes sense to require manual reporting on any non-trivial PR.

@MichaelChirico MichaelChirico merged commit 3130f11 into master May 3, 2024
3 checks passed
@MichaelChirico MichaelChirico deleted the disable-covr branch May 3, 2024 07:27
@MichaelChirico MichaelChirico mentioned this pull request Sep 6, 2024
MichaelChirico added a commit that referenced this pull request Sep 25, 2024
@MichaelChirico MichaelChirico mentioned this pull request Sep 25, 2024
MichaelChirico added a commit that referenced this pull request Sep 26, 2024
* Revert "Disable covr (#6122)"

This reverts commit 3130f11.

* pin R 4.3 with TODO

* Try a pinned covr version

* go further back

* Use cribbed updated covr action?

* Not crashing, but very slow; try pinned version again

* we don't have secrets set up

* Added a repo secret to data.table (I think)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant