Fix staged builders for single component records #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
attn: @gabrielshanahan |
|
Thanks @Randgalt, LGTM! But I would still advocate for generating staged builders even for 0-component record classes. I know that's a slightly weird and probably rare edge-case, but the same logic as described in #177 still applies - you can add a field at any time, and then want the compiler to tell you what you need to change. |
Randgalt
force-pushed
the
jordanz/fix-single-field-staged
branch
from
a14e76c to
09c7262
Compare
|
@gabrielshanahan - I changed to allow no components as well. Please check. |
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #177