Add a ResourceLinks model #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brittanylau
approved these changes
Jan 18, 2021
app.py
Outdated
| Subcategory, | ||
| Criterion, | ||
| Link, | ||
| ResourceLink, |
There was a problem hiding this comment.
Is this import being used?
|
@brittanylau Good call! I made #105 so we remember to update the API once CMS work resumes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that innovative policy idea and honorable mention objects are essentially
Links -- they link to an external URL and are associated with subcategories.I want to create three types of
Links using single table inheritance. The first is the traditional link, which I'm calling aResourceLink. A subcategory can have any number of resource links, and we tell which ones are still being used based on theiractivefield.Two more links,
HonorableMentions andInnovativePolicyIdeas will come in a follow-up PR. These will behave differently thanResourceLinks, which is why I'm making them separate classes.