Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workqueue 去掉timer,使用list排序处理方式 #9817

Closed
wants to merge 2 commits into from

Conversation

yuqingli05
Copy link
Contributor

@yuqingli05 yuqingli05 commented Dec 21, 2024

拉取/合并请求描述:(PR description)

[
并确认并列出已经在什么情况或板卡上进行了测试。
And confirm in which case or board has been tested. -->
bsp\qemu-vexpress-a9

为什么提交这份PR (why to submit this PR)

1、#9814 bug修复
2、去掉每个work的定时器,能大量减少 work的内存占用,和性能优化

你的解决方案是什么 (what is your solution)

去掉work的 timer,只需要在 work线程里面 延迟和同步即可

请提供验证的bsp和config (provide the config and bsp)

  • BSP: bsp\qemu-vexpress-a9
  • .config: 没用改动,直接 menuconfig 生成新的即可
  • action:

测试main函数如下

#include <stdint.h>
#include <stdio.h>
#include <rtthread.h>
#include <rtdevice.h>

struct rt_work work_test0;
struct rt_work work_test1;
struct rt_work work_test2;
struct rt_work work_test3;
struct rt_work work_test4;

void work_func(struct rt_work *work, void *work_data)
{
    rt_kprintf("name=%s tick=%d\n", (char *)work_data, rt_tick_get());
}

int main(void)
{
    rt_kprintf("Hello RT-Thread!\n");
    rt_thread_delay(100);

    rt_work_init(&work_test0, work_func, "work_test0");
    rt_work_init(&work_test1, work_func, "work_test1");
    rt_work_init(&work_test2, work_func, "work_test2");
    rt_work_init(&work_test3, work_func, "work_test3");
    rt_work_init(&work_test4, work_func, "work_test4");
   
    rt_kprintf("test rt_work_urgent tick=%d\n", rt_tick_get());
    rt_work_submit(&work_test0, 100);
    rt_thread_delay(10);
    rt_work_urgent(&work_test0);
    rt_thread_delay(100);
    
    rt_kprintf("test rt_work_submit tick=%d\n", rt_tick_get());
    rt_work_submit(&work_test3, 300);
    rt_work_submit(&work_test1, 100);
    rt_work_submit(&work_test4, 300);
    rt_work_submit(&work_test2, 100);
    rt_thread_delay(250);
    rt_work_submit(&work_test1, 50);
    rt_work_submit(&work_test2, 200);
    rt_thread_delay(300);

    rt_kprintf("test rt_work_cancel tick=%d\n", rt_tick_get());
    rt_work_submit(&work_test1, 50);
    rt_work_submit(&work_test2, 100);
    rt_work_submit(&work_test3, 150);
    rt_thread_delay(50);
    rt_work_cancel(&work_test2);

    return 0;
}

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@yuqingli05 yuqingli05 changed the title My workqueue workqueue 去掉timer,使用list排序处理方式 Dec 21, 2024
@Rbb666 Rbb666 requested a review from mysterywolf December 23, 2024 08:08
@yuqingli05 yuqingli05 closed this Dec 24, 2024
@yuqingli05 yuqingli05 deleted the my-workqueue branch December 24, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant