Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bsp][nxp][mcxa153] the full implementation of eFlexPWM #9788

Merged
merged 3 commits into from
Dec 25, 2024

Conversation

hywing
Copy link
Contributor

@hywing hywing commented Dec 18, 2024

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

implement the real eFlexPWM driver instead of using CTimer

你的解决方案是什么 (what is your solution)

modify files in bsp/nxp/mcx/mcxa/frdm-mcxa153 directory

请提供验证的bsp和config (provide the config and bsp)

  • BSP: bsp/nxp/mcx/mcxa/frdm-mcxa153
  • .config: BSP_USING_PWM0 BSP_USING_PWM1 BSP_USING_PWM2

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@hywing hywing requested a review from Rbb666 as a code owner December 18, 2024 01:01
@github-actions github-actions bot added BSP: NXP Code related with NXP BSP labels Dec 18, 2024
bool "Enable PWM0"
bool "Enable eFlex PWM0"
default N
config BSP_USING_PWM1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注意下缩进

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好了,改了

@@ -129,7 +129,13 @@ menu "On-chip Peripheral Drivers"

if BSP_USING_PWM
config BSP_USING_PWM0
bool "Enable PWM0"
bool "Enable eFlex PWM0"
default N
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

N建议统一改成小写的

@Rbb666 Rbb666 merged commit 54dc928 into RT-Thread:master Dec 25, 2024
46 checks passed
@hywing hywing deleted the devleop branch December 29, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BSP: NXP Code related with NXP BSP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants