[bsp][ht32] 修复编译问题 #9346
[bsp][ht32] 修复编译问题 #9346
Conversation
|
|
| 'USE_HT32F12365_66', | ||
| 'USE_MEM_HT32F12366', | ||
| ('__CLK_TCK','RT_TICK_PER_SECOND'), | ||
| '__STDC_LIMIT_MACROS', | ||
| '__RTTHREAD__', | ||
| 'RT_USING_LIBC', | ||
| 'RT_USING_ARMLIBC', | ||
| 'USE_HT32_DRIVER' |
There was a problem hiding this comment.
感谢提交PR。
这些配置放到menuconfig里面，会保护更好一些。试试看。
There was a problem hiding this comment.
我不是很明白这个bsp/nrf5x是怎么做的，您能给我点信息吗
| 'RT_USING_ARMLIBC', | ||
| 'USE_HT32_DRIVER', | ||
| ('__CLK_TCK', 'RT_TICK_PER_SECOND') | ||
| ] | ||
|
|
||
| group = DefineGroup('Libraries', src, depend = [''], CPPPATH = path, CPPDEFINES = CPPDEFINES) |
There was a problem hiding this comment.
请尝试再CI中添加对应的测试bsp。，参考.github/workflow/bsp_building.yml
| 'USE_HT32F12365_66', | ||
| 'USE_MEM_HT32F12366', | ||
| ('__CLK_TCK','RT_TICK_PER_SECOND'), | ||
| '__STDC_LIMIT_MACROS', | ||
| '__RTTHREAD__', | ||
| 'RT_USING_LIBC', | ||
| 'RT_USING_ARMLIBC', | ||
| 'USE_HT32_DRIVER' |
|
@Rbb666 看下吧，没问题就合并 |
|
我在本地测试是可以的，然后看了ci也没有问题。 |
看下这个 https://supperthomas-wiki.readthedocs.io/10_jiy/04_bsp_support_dist/bsp_support_dist.html |
tools也不一定需要加进去吧？dist出来之后的bsp还需要吗？ |
| 'USE_MEM_HT32F12366', | ||
| ('__CLK_TCK','RT_TICK_PER_SECOND'), | ||
| '__STDC_LIMIT_MACROS', | ||
| '__RTTHREAD__', |
There was a problem hiding this comment.
' RTTHREAD 、RT_USING_LIBC、RT_USING_ARMLIBC、RT_TICK_PER_SECOND'这种系统相关的宏不用添加
There was a problem hiding this comment.
RT_USING_LIBC和RT_USING_ARMLIBC是编译器决定的，可以看这里的定义：
|
|
再理一下nrf5x和这里的差别看看 |
拉取/合并请求描述：(PR description)
[
#7764
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up