-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function for manually writing marker file #584
Conversation
…ro in likwid-marker.h
…ted to writing/reading marker files
Looks good, thanks for your work on the comments. I found a small error in the F90 interface. The function in |
Updated. Looking at the other functions in the same file, I guess I should probably also use the way of passing in the string argument's length and copying it first before passing it to the |
Yes, you should copy the string before providing it to the C functions. |
Okay, I changed it. I also added the missing register macro in the Lua bindings. |
Sorry that I didn't check more thoroughly. I'm on a business trip (SC23) and read your code in between meetings. Next week I have more time to go through your changes. |
No worries, take your time :) |
I looked at your code again and I realized that the new functions/macros do not follow the current naming scheme:
|
Ah, I see, you're right. I'll update them soon |
…rent naming scheme and update bindings accordingly
I think my last commit should have updated all function names accordingly. |
Thanks, that should be all functions for the CPU MarkerAPI. I should probably add similar functions for the Nvidia MarkerAPI and the ROCm MarkerAPI. |
* Add write result file function for Nvidia GPU and AMD GPU. See #584 * Fix bad naming, make local with GPUs and enable appDaemon build if GPU build
Add
likwid_writeMarkerFile
function to address the issue described in #583.