Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function for manually writing marker file #584

Merged
merged 11 commits into from
Dec 18, 2023

Conversation

OoJJBoO
Copy link
Contributor

@OoJJBoO OoJJBoO commented Nov 13, 2023

Add likwid_writeMarkerFile function to address the issue described in #583.

@TomTheBear
Copy link
Member

Looks good, thanks for your work on the comments.

I found a small error in the F90 interface. The function in likwid_f90_interface.c has to have an underscore in the end: likwid_writemarkerfile_.

@OoJJBoO
Copy link
Contributor Author

OoJJBoO commented Nov 16, 2023

Updated. Looking at the other functions in the same file, I guess I should probably also use the way of passing in the string argument's length and copying it first before passing it to the likwid_writeMarkerFile function, right? Didn't notice that earlier for some reason.

@TomTheBear
Copy link
Member

Yes, you should copy the string before providing it to the C functions.

@OoJJBoO
Copy link
Contributor Author

OoJJBoO commented Nov 17, 2023

Okay, I changed it. I also added the missing register macro in the Lua bindings.

@TomTheBear
Copy link
Member

Sorry that I didn't check more thoroughly. I'm on a business trip (SC23) and read your code in between meetings. Next week I have more time to go through your changes.

@OoJJBoO
Copy link
Contributor Author

OoJJBoO commented Nov 17, 2023

No worries, take your time :)

@TomTheBear
Copy link
Member

I looked at your code again and I realized that the new functions/macros do not follow the current naming scheme:

  • likwid_writeMarkerFile -> likwid_markerWriteFile
  • LIKWID_WRITE_MARKER_FILE -> LIKWID_MARKER_WRITE or LIKWID_MARKER_WRITE_FILE
  • likwid_writemarkerfile_ -> likwid_markerwritefile_
  • lua_likwid_writeMarkerFile -> lua_likwid_markerWriteFile

@OoJJBoO
Copy link
Contributor Author

OoJJBoO commented Dec 1, 2023

Ah, I see, you're right. I'll update them soon

…rent naming scheme and update bindings accordingly
@OoJJBoO
Copy link
Contributor Author

OoJJBoO commented Dec 4, 2023

I think my last commit should have updated all function names accordingly.

@TomTheBear
Copy link
Member

Thanks, that should be all functions for the CPU MarkerAPI.

I should probably add similar functions for the Nvidia MarkerAPI and the ROCm MarkerAPI.

@TomTheBear TomTheBear merged commit fe43c12 into RRZE-HPC:master Dec 18, 2023
2 checks passed
TomTheBear added a commit that referenced this pull request Dec 19, 2023
* Add write result file function for Nvidia GPU and AMD GPU. See #584

* Fix bad naming, make local with GPUs and enable appDaemon build if GPU build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants