Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPP Threshold on HOST and HIP #456

Open
wants to merge 45 commits into
base: develop
Choose a base branch
from
Open

RPP Threshold on HOST and HIP #456

wants to merge 45 commits into from
+1,850 −4

Conversation

r-abishek
Copy link
Member

@r-abishek r-abishek commented Sep 25, 2024 •
edited
Loading

  • Updates version to RPP 1.9.7
  • Adds RPP Threshold optimized on AVX2 and HIP
  • Adds relevant unit/perf/QA tests

sampath1117 and others added 22 commits August 12, 2024 13:09
@sampath1117
added initial support for U8 PLN1-PLN1 variant
8921e17
@sampath1117
added support for U8 PKD3, PLN3 variants
04616a0
@sampath1117
modified algorithm to give RGB output for RGB images
007cb7c
@sampath1117
moved common code outside the layout branch conditions
081b8fd
@sampath1117
added support for toggle variation of U8
57b5325
@sampath1117
added golden output for threshold
8507392
@sampath1117
added threshold output for doxygen
8c66fa3
@sampath1117
added support for F32 bit depth
e9f9347
@sampath1117
added support for I8 bitdepth
f61cb53
@sampath1117
added F16 bitdepth support
0a904ac
@sampath1117
added HIP support for U8 bitdepth
8faa129
@sampath1117
made changes to support remaining bitdepths
d361da5
@sampath1117
fixed output issues with I8 variant
d28e55d
@sampath1117
removed commented code in HOST
2acef01
@sampath1117
added threshold test case in maps used in common.py
d739456
@sampath1117
Merge branch 'develop' into sr/opt_threshold
dd5c0ce
@sampath1117
modified RPP_VERSION_MINOR value and changelog
588d639
@sampath1117
fixed issues with doxygen
5941efa 
modified globalThreads_x value for HIP kernel
@sampath1117
Merge branch 'develop' into sr/opt_threshold
67529fd
@sampath1117
made changes in I8 variants as per review comments
658acaa
@sampath1117
added more details for threshold documentation
367b117
@r-abishek
Merge pull request #322 from sampath1117/sr/opt_threshold
7564f90 
RPP Tensor Support - Threshold on HOST and HIP
@r-abishek r-abishek requested a review from a team as a code owner September 25, 2024 15:14
@kiritigowda kiritigowda requested a review from rrawther October 1, 2024 20:19
@kiritigowda kiritigowda self-assigned this Oct 1, 2024
@kiritigowda kiritigowda added enhancement New feature or request ci:precheckin labels Oct 1, 2024
LakshmiKumar23
LakshmiKumar23 approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@LakshmiKumar23 LakshmiKumar23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both HIP and HOST backend passes

spolifroni-amd
spolifroni-amd requested changes Dec 2, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@kiritigowda
Copy link
Collaborator

@r-abishek - needs conflicts resolved

@kiritigowda kiritigowda marked this pull request as draft December 23, 2024 20:28
@r-abishek
Merge pull request #372 from Srihari-mcw/opt_threshold_rebased
61f55cb 
Threshold - Merge Conflicts Update and Duplicate function removal
@r-abishek
Copy link
Member Author

@kiritigowda Conflicts resolved.
CI currently failing due to #492
Tests passing in ROCm 6.2, 6.3. Fails in ROCm 6.4

@kiritigowda kiritigowda marked this pull request as ready for review December 30, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrawther rrawther rrawther approved these changes

@spolifroni-amd spolifroni-amd spolifroni-amd requested changes

@LakshmiKumar23 LakshmiKumar23 LakshmiKumar23 approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@kiritigowda kiritigowda

Labels
ci:precheckin enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@r-abishek @kiritigowda @rrawther @LakshmiKumar23 @spolifroni-amd @sampath1117 @HazarathKumarM @Srihari-mcw