Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto translate #24

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Auto translate #24

wants to merge 5 commits into from

Conversation

richierocks
Copy link
Collaborator

I've added the auto-translation functionality, and it's at a point where I'm fairly happy with it.

Please can you take a look and merge into master. The basic workflow is

translation <- make_translation("es") # or read_translation("es")
auto_translation <- google_translate(translation) # or microsoft_translate(translation)
write_translation(auto_translation)

The Microsoft API has changed since the translateR package was released, which means that package is currently broken. Additionally, it uses mclapply(), which doesn't work on Windows. I contacted the maintainer of translateR last week about the problems, but he hasn't replied. So today I created the autotranslate package, which does exactly the same thing, except that it works.

R CMD check isn't working for me at the moment; I'm getting an error related to building the Vignettes. I didn't touch the vignettes, so I don't think it is related to the autotranslation.

I know that the big pain point with getting people to use this will be the set up. I've included links to the documentation from Google and Microsoft, and it's actually pretty good; I don't think we need to reinvent "how to set up a Google cloud account".

There might be an issue with

Remember that I'm speaking about this at useR on 5th July, and I'll be travelling from 30th June, so it would be great if we can get an updated version of msgtools on CRAN before then.

@richierocks richierocks requested a review from leeper June 26, 2017 02:23
@leeper
Copy link
Member

leeper commented Jul 2, 2017

@richierocks Do you want to take over as maintainer on this? I feel like I can't prioritize it right now and am being kind of a crap collaborator on it frankly.

@richierocks
Copy link
Collaborator Author

OK, sure. I can be maintainer. And don't worry; I understand that you are busy.

@leeper
Copy link
Member

leeper commented Jul 2, 2017

Thank you!! You rock!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants