Refactor: Catch invalid arguments to addItem

REGoth-project · Aug 4, 2019 · 5ce1261 · 5ce1261
1 parent b064eb3
commit 5ce1261
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/components/Inventory.cpp b/src/components/Inventory.cpp
@@ -39,6 +39,11 @@ namespace REGoth
     REGOTH_LOG(Info, Uncategorized, "[Inventory] Add {0}x item {1} to Inventory of {2}", count,
                instance, SO()->getName());
 
+    if (count == 0)
+    {
+      REGOTH_THROW(InvalidParametersException, "Count cannot be 0");
+    }
+
     mItemCountByInstance[instance] += 1;
 
     OnItemChanged(instance);

diff --git a/src/components/UIInventory.cpp b/src/components/UIInventory.cpp
@@ -131,6 +131,11 @@ namespace REGoth
   {
     auto it = mItemsByInstance.find(instance);
 
+    if (count == 0)
+    {
+      REGOTH_THROW(InvalidParametersException, "Count cannot be 0");
+    }
+
     if (it == mItemsByInstance.end())
     {
       auto& item = mItemsByInstance[instance];