Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix for #128 #132

Merged
merged 1 commit into from
May 6, 2024
Merged

bugfix for #128 #132

merged 1 commit into from
May 6, 2024

Conversation

abhishekm2106
Copy link
Contributor

No description provided.

@netlify Netlify
Copy link

netlify bot commented May 5, 2024 •
edited
Loading

✅ Deploy Preview for rcountdown ready!

Name Link
🔨 Latest commit 66135c6
🔍 Latest deploy log https://app.netlify.com/sites/rcountdown/deploys/6637559abdcfa6000838edd4
😎 Deploy Preview https://deploy-preview-132--rcountdown.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@abhishekm2106
Copy link
Contributor Author

just saw that a pr for this already exists

@RDjarbeng RDjarbeng reopened this May 5, 2024
@RDjarbeng
Copy link
Owner

RDjarbeng commented May 5, 2024 •
edited
Loading

You can keep it open, just because a PR exists doesn't mean you should close yours, since it hasn't been merged yet.

@abhishekm2106 can you fix the bug for the send to WhatsApp as well.

I've looked at your implementation.

@RDjarbeng RDjarbeng self-requested a review May 5, 2024 14:36
@RDjarbeng RDjarbeng added the bug fix An issue or bug fix label May 5, 2024
@RDjarbeng
Copy link
Owner

Screenshot of the current behaviour when the whatsapp icon button is clicked:

image

As you can see it should show '../366' and it's still using the hardcoded value

@RDjarbeng
Copy link
Owner

Issue in #133.

@abhishekm2106 You can work on that as part of this PR. That is if you are interested

@RDjarbeng
Copy link
Owner

Closes #128

@RDjarbeng RDjarbeng merged commit ad46e87 into RDjarbeng:master May 6, 2024
4 checks passed
@RDjarbeng RDjarbeng mentioned this pull request May 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyakotey nyakotey nyakotey approved these changes

@RDjarbeng RDjarbeng RDjarbeng approved these changes

Assignees
No one assigned
Labels
bug fix An issue or bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abhishekm2106 @RDjarbeng @nyakotey