Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Days in year for whatsapp share not accurate for leap year #133

Open
RDjarbeng opened this issue May 5, 2024 · 0 comments
Open

Days in year for whatsapp share not accurate for leap year #133

RDjarbeng opened this issue May 5, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@RDjarbeng
Copy link
Owner

This is similar to #128

The day of the year for sharing to whatsapp is showing 365 instead of 366 due to hard coded values.

Recommended fix:

  • The function exportToWhatsapp in js/functions.js should be moved to today.js to make it easier
  • The hard coded value should be replaced with a function call by using the countDays() function in class NewYearClock
@RDjarbeng RDjarbeng added bug Something isn't working good first issue Good for newcomers labels May 5, 2024
@RDjarbeng RDjarbeng mentioned this issue May 5, 2024
Merged
@RDjarbeng RDjarbeng changed the title Days in year for whatsapp share not accurate Days in year for whatsapp share not accurate for leap year May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RDjarbeng